[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

David CARLIER via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 16 07:48:13 PST 2018


devnexen added inline comments.


================
Comment at: lib/Driver/XRayArgs.cpp:56
+                << (std::string(XRayInstrumentOption) + " only on "
+                "FreeBSD x86_64");    
+        }
----------------
krytarowski wrote:
> krytarowski wrote:
> > I think it's better to not hardcode `x86_64` here in a message, we will need change it with new CPUs.
> I think we can reuse the existing above code here as well:
> 
> `<< (std::string(XRayInstrumentOption) + " on " + Triple.str());`
True


https://reviews.llvm.org/D43378





More information about the cfe-commits mailing list