[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

[Kamil Rytarowski via Phabricator via cfe-commits]

krytarowski added inline comments.


================
Comment at: lib/Driver/XRayArgs.cpp:56
+                << (std::string(XRayInstrumentOption) + " only on "
+                "FreeBSD x86_64");    
+        }
----------------
krytarowski wrote:
> I think it's better to not hardcode `x86_64` here in a message, we will need change it with new CPUs.
I think we can reuse the existing above code here as well:

`<< (std::string(XRayInstrumentOption) + " on " + Triple.str());`


================
Comment at: lib/Driver/XRayArgs.cpp:58
+        }
+    } else
       D.Diag(diag::err_drv_clang_unsupported)
----------------
Is this a correct style of `} else` without `{`?

I recommend to use `git-clang-format` to make sure.


https://reviews.llvm.org/D43378