[PATCH] D42942: [clangd] Collect definitions when indexing.

[Eric Liu via Phabricator via cfe-commits]

ioeric added a comment.

looks good



================
Comment at: clangd/index/Index.h:25
 
 struct SymbolLocation {
   // The absolute path of the source file where a symbol occurs.
----------------
It might be worth mentioning here whether the range covers the entire declaration/definition body, or just the symbol identifier.


================
Comment at: clangd/index/Merge.cpp:71
+  if (!S.CanonicalDeclaration || R.Definition)
     S.CanonicalDeclaration = R.CanonicalDeclaration;
   if (S.CompletionLabel == "")
----------------
Do we also need to copy other information such as completion detail, since forward declarations usually have minimum symbol information?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42942