[PATCH] D42942: [clangd] Collect definitions when indexing.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

This does seem to get at least the simple cases right:

  ID:              0EF8ACCCCF4D08B11EBF3FFB8004CE702991B15F
  Name:            SymbolsFromYAML
  Scope:           'clang::clangd::'
  SymInfo:         
    Kind:            Function
    Lang:            C
  CanonicalDeclaration: 
    StartOffset:     956
    EndOffset:       1010
    FilePath:        /usr/local/google/home/sammccall/src/llvm/tools/clang/tools/extra/clangd/index/SymbolYAML.h
  Definition:      
    StartOffset:     4999
    EndOffset:       5348
    FilePath:        /usr/local/google/home/sammccall/src/llvm/tools/clang/tools/extra/clangd/index/SymbolYAML.cpp
  CompletionLabel: 'SymbolsFromYAML(llvm::StringRef YAMLContent)'
  CompletionFilterText: SymbolsFromYAML
  CompletionPlainInsertText: SymbolsFromYAML
  CompletionSnippetInsertText: 'SymbolsFromYAML(${1:llvm::StringRef YAMLContent})'
  Detail:          
    Documentation:   ''
    CompletionDetail: SymbolSlab


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42942