r322549 - Squash -Wcovered-switch-default wairning

[Sam McCall via cfe-commits]

Fixed in r322672.
(Slightly awkwardly, because we don't have llvm_unreachable in C)

On Tue, Jan 16, 2018 at 11:52 PM, Galina Kistanova <gkistanova at gmail.com>
wrote:

> Hello Sam,
>
> This commit broke one of our builders:
> http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4517
>
> . . .
> FAILED: /usr/local/gcc-7.1/bin/gcc-7.1  -DGTEST_HAS_RTTI=0 -D_DEBUG
> -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
> -D__STDC_LIMIT_MACROS -Itools/clang/tools/c-index-test
> -I/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/tools/clang/tools/c-index-test
> -I/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/tools/clang/include
> -Itools/clang/include -Iinclude -I/home/buildslave/am1i-slv2/
> ubuntu-gcc7.1-werror/llvm/include -fPIC -Werror -Werror=date-time -Wall
> -W -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers
> -pedantic -Wno-long-long -Wno-comment -ffunction-sections -fdata-sections
> -O3    -UNDEBUG -std=gnu89 -MD -MT tools/clang/tools/c-index-
> test/CMakeFiles/c-index-test.dir/c-index-test.c.o -MF
> tools/clang/tools/c-index-test/CMakeFiles/c-index-test.dir/c-index-test.c.o.d
> -o tools/clang/tools/c-index-test/CMakeFiles/c-index-test.dir/c-index-test.c.o
> -c /home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/
> tools/clang/tools/c-index-test/c-index-test.c
> /home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/
> tools/clang/tools/c-index-test/c-index-test.c: In function ‘CursorToText’:
> /home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/
> tools/clang/tools/c-index-test/c-index-test.c:741:1: error: control
> reaches end of non-void function [-Werror=return-type]
>  }
>  ^
> cc1: all warnings being treated as errors
>
> Please have a look?
>
> Thanks
>
> Galina
>
> On Tue, Jan 16, 2018 at 4:54 AM, Sam McCall via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
>> Author: sammccall
>> Date: Tue Jan 16 04:54:28 2018
>> New Revision: 322549
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=322549&view=rev
>> Log:
>> Squash -Wcovered-switch-default wairning
>>
>> Modified:
>>     cfe/trunk/tools/c-index-test/c-index-test.c
>>
>> Modified: cfe/trunk/tools/c-index-test/c-index-test.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/c-index-
>> test/c-index-test.c?rev=322549&r1=322548&r2=322549&view=diff
>> ============================================================
>> ==================
>> --- cfe/trunk/tools/c-index-test/c-index-test.c (original)
>> +++ cfe/trunk/tools/c-index-test/c-index-test.c Tue Jan 16 04:54:28 2018
>> @@ -729,8 +729,7 @@ static CXString CursorToText(CXCursor Cu
>>      return clang_getCursorSpelling(Cursor);
>>    case DisplayType_DisplayName:
>>      return clang_getCursorDisplayName(Cursor);
>> -  case DisplayType_Pretty:
>> -  default: {
>> +  case DisplayType_Pretty: {
>>      CXString text;
>>      CXPrintingPolicy Policy = clang_getCursorPrintingPolicy(Cursor);
>>      ModifyPrintingPolicyAccordingToEnv(Policy);
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180117/fc0594f0/attachment-0001.html>