<div dir="ltr">Fixed in r322672.<div>(Slightly awkwardly, because we don't have llvm_unreachable in C)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 16, 2018 at 11:52 PM, Galina Kistanova <span dir="ltr"><<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hello Sam,<br><br>This commit broke one of our builders:<br><a href="http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4517" target="_blank">http://lab.llvm.org:8011/<wbr>builders/ubuntu-gcc7.1-werror/<wbr>builds/4517</a><br><br>. . .<br>FAILED: /usr/local/gcc-7.1/bin/gcc-7.<wbr>1  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/c-index-<wbr>test -I/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/<wbr>tools/clang/tools/c-index-test -I/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/<wbr>tools/clang/include -Itools/clang/include -Iinclude -I/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/<wbr>include -fPIC -Werror -Werror=date-time -Wall -W -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-<wbr>initializers -pedantic -Wno-long-long -Wno-comment -ffunction-sections -fdata-sections -O3    -UNDEBUG -std=gnu89 -MD -MT tools/clang/tools/c-index-<wbr>test/CMakeFiles/c-index-test.<wbr>dir/c-index-test.c.o -MF tools/clang/tools/c-index-<wbr>test/CMakeFiles/c-index-test.<wbr>dir/c-index-test.c.o.d -o tools/clang/tools/c-index-<wbr>test/CMakeFiles/c-index-test.<wbr>dir/c-index-test.c.o   -c /home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/<wbr>tools/clang/tools/c-index-<wbr>test/c-index-test.c<br>/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/<wbr>tools/clang/tools/c-index-<wbr>test/c-index-test.c: In function ‘CursorToText’:<br>/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/<wbr>tools/clang/tools/c-index-<wbr>test/c-index-test.c:741:1: error: control reaches end of non-void function [-Werror=return-type]<br> }<br> ^<br>cc1: all warnings being treated as errors<br><br>Please have a look?<br><br>Thanks<br><br>Galina<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 16, 2018 at 4:54 AM, Sam McCall via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sammccall<br>
Date: Tue Jan 16 04:54:28 2018<br>
New Revision: 322549<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=322549&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=322549&view=rev</a><br>
Log:<br>
Squash -Wcovered-switch-default wairning<br>
<br>
Modified:<br>
    cfe/trunk/tools/c-index-test/c<wbr>-index-test.c<br>
<br>
Modified: cfe/trunk/tools/c-index-test/c<wbr>-index-test.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/c-index-test/c-index-test.c?rev=322549&r1=322548&r2=322549&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/cfe/trunk/tools/c-index-<wbr>test/c-index-test.c?rev=322549<wbr>&r1=322548&r2=322549&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/tools/c-index-test/c<wbr>-index-test.c (original)<br>
+++ cfe/trunk/tools/c-index-test/c<wbr>-index-test.c Tue Jan 16 04:54:28 2018<br>
@@ -729,8 +729,7 @@ static CXString CursorToText(CXCursor Cu<br>
     return clang_getCursorSpelling(Cursor<wbr>);<br>
   case DisplayType_DisplayName:<br>
     return clang_getCursorDisplayName(Cur<wbr>sor);<br>
-  case DisplayType_Pretty:<br>
-  default: {<br>
+  case DisplayType_Pretty: {<br>
     CXString text;<br>
     CXPrintingPolicy Policy = clang_getCursorPrintingPolicy(<wbr>Cursor);<br>
     <wbr>ModifyPrintingPolicyAccordingT<wbr>oEnv(Policy);<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div>