[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

[Simon Dardis via Phabricator via cfe-commits]

sdardis added a comment.

I just checked both my qemu copy and  on my mips64 machine and it seems to be a a copy / paste error. Reposting here directly from my machines:

MIPS64:

  diff --git a/test/libunwind/test/config.py b/test/libunwind/test/config.py
  index 2a0c828..a8952c3 100644
  --- a/test/libunwind/test/config.py
  +++ b/test/libunwind/test/config.py
  @@ -48,6 +48,8 @@ class Configuration(LibcxxConfiguration):
           # Stack unwinding tests need unwinding tables and these are not
           # generated by default on all Targets.
           self.cxx.compile_flags += ['-funwind-tables']
  +       self.cxx.compile_flags += ['-mabi=n32']
  +        self.cxx.link_flags += ['-mabi=n32']
           if not self.get_lit_bool('enable_threads', True):
               self.cxx.compile_flags += ['-D_LIBUNWIND_HAS_NO_THREADS']
               self.config.available_features.add('libunwind-no-threads')

X86_64:

  diff --git a/test/libunwind/test/config.py b/test/libunwind/test/config.py
  index 2a0c828..f1953e2 100644
  --- a/test/libunwind/test/config.py
  +++ b/test/libunwind/test/config.py
  @@ -48,6 +48,8 @@ class Configuration(LibcxxConfiguration):
           # Stack unwinding tests need unwinding tables and these are not
           # generated by default on all Targets.
           self.cxx.compile_flags += ['-funwind-tables']
  +       self.cxx.compile_flags += ['-mabi=n32']
  +        self.cxx.link_flags += ['-mabi=n32', '/home/sdardis/mips-mti-linux-gnu/2016.05-06/bin/../lib/gcc/mips-mti-linux-gnu/4.9.2/../../../../mips-mti-linux-gnu/lib/mips-r2-hard/lib32/libgcc_s.so.1']
           if not self.get_lit_bool('enable_threads', True):
               self.cxx.compile_flags += ['-D_LIBUNWIND_HAS_NO_THREADS']
               self.config.available_features.add('libunwind-no-threads')

I corrected whitespace nit before I posted the comment.


https://reviews.llvm.org/D39074