[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.
John Baldwin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 12 12:48:10 PST 2018
bsdjhb added a comment.
In https://reviews.llvm.org/D39074#974913, @sdardis wrote:
> This was libunwind's test suite:
>
> Compiled test failed unexpectedly!
> ********************
> Testing Time: 0.53s
> ********************
> Failing Tests (1):
> libunwind :: libunwind_02.pass.cpp
>
> Expected Passes : 3
> Unexpected Failures: 1
>
>
>
> The hacky patch I used to test n32:
>
> --- a/test/libunwind/test/config.py
> +++ b/test/libunwind/test/config.py
> @@ -48,6 +48,8 @@ class Configuration(LibcxxConfiguration):
> # Stack unwinding tests need unwinding tables and these are not
> # generated by default on all Targets.
> self.cxx.compile_flags += ['-funwind-tables']
> + self.cxx.compile_flags += ['-mabi=n33']
> + self.cxx.link_flags += ['-mabi=n32']
> if not self.get_lit_bool('enable_threads', True):
> self.cxx.compile_flags += ['-D_LIBUNWIND_HAS_NO_THREADS']
> self.config.available_features.add('libunwind-no-threads')
>
>
Just to be sure, is that '-mabi=n33' in the compile flags a copy and paste typo in the diff or do you have it locally in the real change as well?
https://reviews.llvm.org/D39074
More information about the cfe-commits
mailing list