[PATCH] D39903: [libclang] Allow pretty printing declarations

[Nikolai Kosjar via Phabricator via cfe-commits]

nik marked an inline comment as done.
nik added inline comments.


================
Comment at: tools/libclang/CIndex.cpp:4782
+
+  return 0;
+}
----------------
jbcoe wrote:
> Might be worth asserting here.
Good idea. I've done the same for the setter.


================
Comment at: unittests/libclang/LibclangTest.cpp:596
+TEST_F(LibclangPrintingPolicyTest, GetProperty) {
+  EXPECT_EQ(2U, clang_PrintingPolicy_getProperty(Policy, CXPrintingPolicy_Indentation));
+}
----------------
jbcoe wrote:
> It would be useful, albeit tedious, to add get/set test pairs for each property.
I think we have the basic functionality of the getter and setter covered. Testing each getter/setter for each property would mostly help to verify the mapping in the getters/setters - initially I've ruled out that possibility with the macros (once the macro is correct - but that's much easier to check). I would prefer to go back to the macro version than adding  a test here that goes over all properties.


Repository:
  rC Clang

https://reviews.llvm.org/D39903