[PATCH] D39903: [libclang] Allow pretty printing declarations

[Jonathan B Coe via Phabricator via cfe-commits]

jbcoe added a comment.

Looking good, only a few nits.



================
Comment at: tools/libclang/CIndex.cpp:4782
+
+  return 0;
+}
----------------
Might be worth asserting here.


================
Comment at: unittests/libclang/LibclangTest.cpp:596
+TEST_F(LibclangPrintingPolicyTest, GetProperty) {
+  EXPECT_EQ(2U, clang_PrintingPolicy_getProperty(Policy, CXPrintingPolicy_Indentation));
+}
----------------
It would be useful, albeit tedious, to add get/set test pairs for each property.


Repository:
  rC Clang

https://reviews.llvm.org/D39903