r321312 - [AST] Incorrectly qualified unscoped enumeration as template actual parameter.
Robinson, Paul via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 26 10:02:50 PST 2017
r321457. Happy new year!
> -----Original Message-----
> From: Kim Gräsman [mailto:kim.grasman at gmail.com]
> Sent: Tuesday, December 26, 2017 1:56 AM
> To: Robinson, Paul
> Cc: cfe-commits
> Subject: Re: r321312 - [AST] Incorrectly qualified unscoped enumeration as
> template actual parameter.
> This broke a test case in IWYU, so I read the diff a few times more
> than usual...
> On Thu, Dec 21, 2017 at 10:47 PM, Paul Robinson via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> > // scope of the enumeration.
> > - if (ED->isScoped() || ED->getIdentifier())
> > + // For the case of unscoped enumerator, do not include in the
> > + // name any information about its enum enclosing scope, as is
> > + // is global.
> Typo: as is -> as its
> Happy holidays,
> - Kim
More information about the cfe-commits