r321312 - [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

Kim Gräsman via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 26 01:55:32 PST 2017


This broke a test case in IWYU, so I read the diff a few times more
than usual...

On Thu, Dec 21, 2017 at 10:47 PM, Paul Robinson via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
>        // scope of the enumeration.
> -      if (ED->isScoped() || ED->getIdentifier())
> +      // For the case of unscoped enumerator, do not include in the qualified
> +      // name any information about its enum enclosing scope, as is visibility
> +      // is global.


Typo: as is -> as its

Happy holidays,
- Kim


More information about the cfe-commits mailing list