[PATCH] D40952: [clangd] Convert lit code completion tests to unit-tests. NFC

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.

lg



================
Comment at: unittests/clangd/Matchers.h:54
+  bool MatchAndExplain(const std::vector<T> &V,
+                       ::testing::MatchResultListener *L) const {
+    std::vector<int> Matches(Matchers.size());
----------------
`override`?


================
Comment at: unittests/clangd/Matchers.h:77
+
+template <typename... M> class PolySubsequenceMatcher {
+  std::tuple<M...> Matchers;
----------------
It would be helpful to provide a bit documentation here.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D40952