[PATCH] D40952: [clangd] Convert lit code completion tests to unit-tests. NFC

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 8 02:35:32 PST 2017


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: unittests/clangd/CodeCompleteTests.cpp:289
+    };
+    void Foo::pub() { this->^ }
+  )cpp");
----------------
The `^` symbol conflicts with the corresponding operator.
Even though it's not widely used, I'm wondering whether we should use a different marker for completion position.


================
Comment at: unittests/clangd/CodeCompleteTests.cpp:335
+  )cpp",
+                             Opts);
+  EXPECT_THAT(Results.items,
----------------
The formatting is a bit weird. Is this a `clang-format` bug?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D40952





More information about the cfe-commits mailing list