[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79
   QualifiedRenameRule(const NamedDecl *ND,
-                      std::string NewQualifiedName)
+                      const std::string &NewQualifiedName)
       : ND(ND), NewQualifiedName(std::move(NewQualifiedName)) {}
----------------
Quolyk wrote:
> hokein wrote:
> > Passing `std::string` object is fine here -- because we use std::move below to avoid the extra copy.
> > 
> > Is the warning caught by the clang-tidy check?
> Unfortunatelly, I haven't tested, but I believe it's checkcpp warning.
I think this is a false positive of the checkcpp.

There is a similar clang-tidy "performance-unnecessary-value-param" check, but I don't think the check will warn this case.




https://reviews.llvm.org/D40543