[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

[Dmitry Venikov via Phabricator via cfe-commits]

Quolyk added inline comments.


================
Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79
   QualifiedRenameRule(const NamedDecl *ND,
-                      std::string NewQualifiedName)
+                      const std::string &NewQualifiedName)
       : ND(ND), NewQualifiedName(std::move(NewQualifiedName)) {}
----------------
hokein wrote:
> Passing `std::string` object is fine here -- because we use std::move below to avoid the extra copy.
> 
> Is the warning caught by the clang-tidy check?
Unfortunatelly, I haven't tested, but I believe it's checkcpp warning.


https://reviews.llvm.org/D40543