[PATCH] D39831: [Driver] Make the use of relax relocations a per target option

[Petr Hosek via cfe-commits]

That's the Fuchsia CMake cache file which is used to build Fuchsia
toolchain, it's not needed there anymore because Fuchsia Clang driver now
handles this. I haven't touched Clang's CMakeLists.txt which defines
the ENABLE_X86_RELAX_RELOCATIONS option.

On Tue, Nov 21, 2017 at 3:14 PM Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> I am probably missing something, but the patch has
>
> -# This is a "Does your linker support it?" option that only applies
> -# to x86-64 ELF targets.  All Fuchsia target linkers do support it.
> -# For x86-64 Linux, it's supported by LLD and by GNU linkers since
> -# binutils 2.27, so one can hope that all Linux hosts in use handle it.
> -# Ideally this would be settable as a per-target option.
> -set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")
>
> And I don't see what that is replaced with.
>
> Cheers,
> Rafael
>
> Petr Hosek <phosek at google.com> writes:
>
> > I kept the CMake option, so by default the driver will use the value set
> > through CMake as before but individual targets can now set their platform
> > default.
> >
> > On Tue, Nov 21, 2017 at 1:30 PM Rafael Avila de Espindola <
> > rafael.espindola at gmail.com> wrote:
> >
> >> Petr Hosek via Phabricator <reviews at reviews.llvm.org> writes:
> >>
> >>
> >> > -# This is a "Does your linker support it?" option that only applies
> >> > -# to x86-64 ELF targets.  All Fuchsia target linkers do support it.
> >> > -# For x86-64 Linux, it's supported by LLD and by GNU linkers since
> >> > -# binutils 2.27, so one can hope that all Linux hosts in use handle
> it.
> >> > -# Ideally this would be settable as a per-target option.
> >> > -set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")
> >> > -
> >>
> >> We still have to be able to set it via cmake.
> >>
> >> Cheers,
> >> Rafeal
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171121/58e93a32/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4843 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171121/58e93a32/attachment.bin>