[PATCH] D39831: [Driver] Make the use of relax relocations a per target option

[Rafael Avila de Espindola via cfe-commits]

I am probably missing something, but the patch has

-# This is a "Does your linker support it?" option that only applies
-# to x86-64 ELF targets.  All Fuchsia target linkers do support it.
-# For x86-64 Linux, it's supported by LLD and by GNU linkers since
-# binutils 2.27, so one can hope that all Linux hosts in use handle it.
-# Ideally this would be settable as a per-target option.
-set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")

And I don't see what that is replaced with.

Cheers,
Rafael

Petr Hosek <phosek at google.com> writes:

> I kept the CMake option, so by default the driver will use the value set
> through CMake as before but individual targets can now set their platform
> default.
>
> On Tue, Nov 21, 2017 at 1:30 PM Rafael Avila de Espindola <
> rafael.espindola at gmail.com> wrote:
>
>> Petr Hosek via Phabricator <reviews at reviews.llvm.org> writes:
>>
>>
>> > -# This is a "Does your linker support it?" option that only applies
>> > -# to x86-64 ELF targets.  All Fuchsia target linkers do support it.
>> > -# For x86-64 Linux, it's supported by LLD and by GNU linkers since
>> > -# binutils 2.27, so one can hope that all Linux hosts in use handle it.
>> > -# Ideally this would be settable as a per-target option.
>> > -set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")
>> > -
>>
>> We still have to be able to set it via cmake.
>>
>> Cheers,
>> Rafeal
>>