[PATCH] D39627: Fix vtable not receiving hidden visibility when using push(visibility)

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

In https://reviews.llvm.org/D39627#917175, @efriedma wrote:

> Adding cfe-commits.  (In the future, please make sure to CC that list instead of llvm-commits for clang changes.)
>
> > I'm missing some background lingo here. What is the meaning of "a declaration" and "a definition" here?
>
> In most cases, we only emit the vtable for a class in one object file.  Informally, we can call that the "definition" of the vtable, as an analogy to variables and functions.  See also http://itanium-cxx-abi.github.io/cxx-abi/abi.html#vague-vtable .


LLVM also distinguishes between a declaration (a Function or GlobalVariable which is presumed to be defined in a different Module) vs. a definition.


Repository:
  rL LLVM

https://reviews.llvm.org/D39627