[PATCH] D39702: [test-suite] [CUDA] Delete nexttoward and nextafter CUDA tests, because these functions have no implementations.
Justin Lebar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 6 15:04:55 PST 2017
jlebar created this revision.
Herald added a subscriber: sanjoy.
These functions never actually worked -- if you called them, you'd get a
ptxas error when llvm tried to make a libcall to e.g. nexttowardf.
This test only compiled because the calls were DCE'ed. Sadly my
laziness in not checking the return value of these functions resulted in
this long-standing bug.
On the upside, we check the return values of all other math functions,
so this bug is limited to nexttoward and nextafter.
https://reviews.llvm.org/D39702
Files:
External/CUDA/cmath.cu
External/CUDA/math_h.cu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39702.121799.patch
Type: text/x-patch
Size: 6534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171106/6b9eda7f/attachment-0001.bin>
More information about the cfe-commits
mailing list