[PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

[Volodymyr Sapsai via cfe-commits]

For now it is gone in the meaning that you don’t have to dedicate time and effort to support this configuration. But I wouldn’t say that taking other dependencies on llvm is welcome. In this aspect nothing has changed.

> On Nov 3, 2017, at 15:22, Zachary Turner <zturner at google.com> wrote:
> 
> The reason I ask is because I remember several months ago when I originally made these changes, there was quite a bit of difficulty because some of the Jenkins builders were wanting to run libcxx tests without any llvm source tree on the machine.
> 
> Does this configuration still exist, or is it gone?  If it is gone, I think many libcxx maintainers would be very happy if they can assume the presence of an LLVM source tree somewhere on the disk.
> 
> On Fri, Nov 3, 2017 at 3:18 PM Volodymyr Sapsai <vsapsai at apple.com <mailto:vsapsai at apple.com>> wrote:
> We have llvm source tree next to libcxx and configure libcxx with -DLLVM_PATH.
> 
> 
>> On Nov 2, 2017, at 16:53, Zachary Turner <zturner at google.com <mailto:zturner at google.com>> wrote:
>> 
>> No problem.  If you don't mind me asking, what was the configuration change you made?  Or do you have a link to the patch which fixed it that I can look at?
>> 
>> On Thu, Nov 2, 2017 at 4:43 PM Volodymyr Sapsai via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
>> vsapsai abandoned this revision.
>> vsapsai added a comment.
>> 
>> Fixed by changing libcxx build configuration, no CMake change required.
>> 
>> 
>> https://reviews.llvm.org/D39520 <https://reviews.llvm.org/D39520>
>> 
>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171103/f6621b5b/attachment.html>