<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">For now it is gone in the meaning that you don’t have to dedicate time and effort to support this configuration. But I wouldn’t say that taking other dependencies on llvm is welcome. In this aspect nothing has changed.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Nov 3, 2017, at 15:22, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">The reason I ask is because I remember several months ago when I originally made these changes, there was quite a bit of difficulty because some of the Jenkins builders were wanting to run libcxx tests without any llvm source tree on the machine.<div class=""><br class=""></div><div class="">Does this configuration still exist, or is it gone? If it is gone, I think many libcxx maintainers would be very happy if they can assume the presence of an LLVM source tree somewhere on the disk.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Nov 3, 2017 at 3:18 PM Volodymyr Sapsai <<a href="mailto:vsapsai@apple.com" class="">vsapsai@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class="">We have llvm source tree next to libcxx and configure libcxx with -DLLVM_PATH.</div><div style="word-wrap:break-word;line-break:after-white-space" class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Nov 2, 2017, at 16:53, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank" class="">zturner@google.com</a>> wrote:</div><br class="m_-9132299857432366412Apple-interchange-newline"><div class=""><div dir="ltr" class="">No problem. If you don't mind me asking, what was the configuration change you made? Or do you have a link to the patch which fixed it that I can look at?</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Nov 2, 2017 at 4:43 PM Volodymyr Sapsai via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vsapsai abandoned this revision.<br class="">
vsapsai added a comment.<br class="">
<br class="">
Fixed by changing libcxx build configuration, no CMake change required.<br class="">
<br class="">
<br class="">
<a href="https://reviews.llvm.org/D39520" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D39520</a><br class="">
<br class="">
<br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></blockquote></div>
</div></blockquote></div><br class=""></body></html>