[PATCH] D39430: [clangd] formatting: don't ignore style

Raoul Wols via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 3 12:29:03 PDT 2017


rwols marked 2 inline comments as done.
rwols added inline comments.


================
Comment at: clangd/ClangdServer.cpp:41
   // Call clang-format.
-  // FIXME: Don't ignore style.
-  format::FormatStyle Style = format::getLLVMStyle();
-  auto Result = format::reformat(Style, Code, Ranges, Filename);
-
+  auto StyleOrError = format::getStyle("file", Filename, "LLVM");
+  if (!StyleOrError)
----------------
sammccall wrote:
> This needs to use the VFS I think. (I'm not familiar with the details of the VFS usage I'm afraid)
Haven't tried implementing this yet, but from some simple experiments it doesn't seem necessary.


https://reviews.llvm.org/D39430





More information about the cfe-commits mailing list