[PATCH] D39430: [clangd] formatting: don't ignore style

Raoul Wols via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 3 12:27:34 PDT 2017


rwols updated this revision to Diff 121524.
rwols added a comment.

Use llvm::Error for beautiful handling of errors.

It's perhaps an idea to write a `replyExpected(llvm::Expected<T>)`, that will
transparently handle `llvm::Error`s.

I'll write a unit test for these changes next.

It's probably best to wait for https://reviews.llvm.org/D39435 to land, and then rebase.


https://reviews.llvm.org/D39430

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/JSONRPCDispatcher.cpp
  clangd/JSONRPCDispatcher.h
  test/clangd/formatting.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39430.121524.patch
Type: text/x-patch
Size: 7144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171103/4c4d40d8/attachment.bin>


More information about the cfe-commits mailing list