r315126 - Driver: hoist the `wchar_t` handling to the driver
Friedman, Eli via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 25 13:32:28 PDT 2017
On 10/25/2017 12:49 PM, Reid Kleckner wrote:
> On Wed, Oct 25, 2017 at 12:14 PM, Friedman, Eli
> <efriedma at codeaurora.org <mailto:efriedma at codeaurora.org>> wrote:
>
> Maybe we should just ignore -fno-short-wchar, instead? I think
> that's what gcc and released versions of clang do (that means
> -fno-short-wchar doesn't do anything for Windows targets, but
> that's probably fine).
>
>
> No, the intention of this change was to make -fno-short-wchar do
> something on Windows targets.
Really? I don't see any mention of that in either the patch itself, or
in the discussion of it. It's fine, I guess, but please add a note to
the release notes.
-Eli
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171025/46b19ee9/attachment.html>
More information about the cfe-commits
mailing list