<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 10/25/2017 12:49 PM, Reid Kleckner
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CACs=tyJ3B4DDuzub0-n56eWvvnkiLXjAdrdjkAFqUV2KkSoo_A@mail.gmail.com">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Wed, Oct 25, 2017 at 12:14 PM,
Friedman, Eli <span dir="ltr"><<a
href="mailto:efriedma@codeaurora.org" target="_blank"
moz-do-not-send="true">efriedma@codeaurora.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>
<div class="h5">
<div class="m_4269100519850321198moz-cite-prefix"><span
style="color:rgb(34,34,34)">Maybe we should just
ignore -fno-short-wchar, instead? I think
that's what gcc and released versions of clang
do (that means -fno-short-wchar doesn't do
anything for Windows targets, but that's
probably fine).</span></div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>No, the intention of this change was to make
-fno-short-wchar do something on Windows targets. </div>
</div>
</div>
</div>
</blockquote>
<p>Really? I don't see any mention of that in either the patch
itself, or in the discussion of it. It's fine, I guess, but
please add a note to the release notes.</p>
<p>-Eli<br>
</p>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</body>
</html>