[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 18:38:00 PDT 2017


klimek added a comment.

Ok, I think this is starting to look really good. Now we should try to grab Richard's attention to make sure it's fine to submit with the current set of FIXMEs.



================
Comment at: lib/Frontend/FrontendActions.cpp:386
+  // This part is normally done by ASTFrontEndAction, but needs to happen
+  //  before Templight observers can be created ----------------------->>
+  // FIXME: Move the truncation aspect of this into Sema, we delayed this till
----------------
Usually we don't use ascii art. Perhaps instead of marking a scope with arrows, pull out a small function that explains what we want to do instead?


https://reviews.llvm.org/D5767





More information about the cfe-commits mailing list