[PATCH] D38986: [Analyzer] Better unreachable message in enumeration

[George Karpenkov via Phabricator via cfe-commits]

george.karpenkov added a comment.

@dcoughlin

> Is it when an end-user is running a build with assertions and can't provide a reproducer but can provide the console output?

Yes, or just for developer staring at the crash for the first time, or for the crashers in CI.

> Does llvm_unreachable() guarantee that the string construction code is completely removed from release builds?

I am not sure what do you mean, the string construction code would only be encountered when we are in the `default` branch, which would mean that we are crashing already. Or do you worry about the code size being slightly larger?


https://reviews.llvm.org/D38986