r316152 - Fix a few nits in RenamingAction.

[Alex L via cfe-commits]

Thanks!

On 19 October 2017 at 01:20, Haojian Wu via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: hokein
> Date: Thu Oct 19 01:20:55 2017
> New Revision: 316152
>
> URL: http://llvm.org/viewvc/llvm-project?rev=316152&view=rev
> Log:
> Fix a few nits in RenamingAction.
>
> * Add missing override keyword.
> * avoid unnecessary copy of std::string.
>
> Modified:
>     cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
>
> Modified: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/
> Refactoring/Rename/RenamingAction.cpp?rev=316152&
> r1=316151&r2=316152&view=diff
> ============================================================
> ==================
> --- cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp (original)
> +++ cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp Thu Oct
> 19 01:20:55 2017
> @@ -77,10 +77,10 @@ private:
>  class RenameOccurrences final : public SourceChangeRefactoringRule {
>  public:
>    RenameOccurrences(const NamedDecl *ND, std::string NewName)
> -      : Finder(ND), NewName(NewName) {}
> +      : Finder(ND), NewName(std::move(NewName)) {}
>
>    Expected<AtomicChanges>
> -  createSourceReplacements(RefactoringRuleContext &Context) {
> +  createSourceReplacements(RefactoringRuleContext &Context) override {
>      Expected<SymbolOccurrences> Occurrences =
>          Finder.findSymbolOccurrences(Context);
>      if (!Occurrences)
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171019/1f5a13ac/attachment-0001.html>