<div dir="ltr">Thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On 19 October 2017 at 01:20, Haojian Wu via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hokein<br>
Date: Thu Oct 19 01:20:55 2017<br>
New Revision: 316152<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=316152&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=316152&view=rev</a><br>
Log:<br>
Fix a few nits in RenamingAction.<br>
<br>
* Add missing override keyword.<br>
* avoid unnecessary copy of std::string.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Tooling/<wbr>Refactoring/Rename/<wbr>RenamingAction.cpp<br>
<br>
Modified: cfe/trunk/lib/Tooling/<wbr>Refactoring/Rename/<wbr>RenamingAction.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp?rev=316152&r1=316151&r2=316152&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/Tooling/<wbr>Refactoring/Rename/<wbr>RenamingAction.cpp?rev=316152&<wbr>r1=316151&r2=316152&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/Tooling/<wbr>Refactoring/Rename/<wbr>RenamingAction.cpp (original)<br>
+++ cfe/trunk/lib/Tooling/<wbr>Refactoring/Rename/<wbr>RenamingAction.cpp Thu Oct 19 01:20:55 2017<br>
@@ -77,10 +77,10 @@ private:<br>
 class RenameOccurrences final : public SourceChangeRefactoringRule {<br>
 public:<br>
   RenameOccurrences(const NamedDecl *ND, std::string NewName)<br>
-      : Finder(ND), NewName(NewName) {}<br>
+      : Finder(ND), NewName(std::move(NewName)) {}<br>
<br>
   Expected<AtomicChanges><br>
-  createSourceReplacements(<wbr>RefactoringRuleContext &Context) {<br>
+  createSourceReplacements(<wbr>RefactoringRuleContext &Context) override {<br>
     Expected<SymbolOccurrences> Occurrences =<br>
         Finder.findSymbolOccurrences(<wbr>Context);<br>
     if (!Occurrences)<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>