[PATCH] D37001: [clang-diff] Use data collectors for node comparison

Johannes Altmanninger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 00:28:08 PDT 2017

johannes added inline comments.

Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:537
+#include "../../AST/DeclDataCollectors.inc"
arphaman wrote:
> I didn't realize that you're including files from within `lib`. That's not ideal. You should add a pre-commit that moves the *.inc files over to include/AST (and marks them as textual in Clang's `module.modulemap`). Then you should include them using the clang/AST path.
I tried moving StmtDataCollectors.inc to and adding
`+  textual header "AST/StmtDataCollectors.inc" `
in the modulemap, then I get some CMake errors, not sure why.

It might make sense to tablegen it like the other .inc files.


More information about the cfe-commits mailing list