[PATCH] D37001: [clang-diff] Use data collectors for node comparison

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 09:00:51 PDT 2017

arphaman added inline comments.

Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:537
+#include "../../AST/DeclDataCollectors.inc"
I didn't realize that you're including files from within `lib`. That's not ideal. You should add a pre-commit that moves the *.inc files over to include/AST (and marks them as textual in Clang's `module.modulemap`). Then you should include them using the clang/AST path.


More information about the cfe-commits mailing list