[PATCH] D33852: Enable __declspec(selectany) on linux

Piotr Padlewski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 10:56:50 PDT 2017

Prazek added inline comments.

Comment at: include/clang/Basic/Attr.td:2477
   let Spellings = [Declspec<"selectany">, GCC<"selectany">];
   let Documentation = [Undocumented];
aaron.ballman wrote:
> aaron.ballman wrote:
> > Since we're drastically modifying what platforms this is supported on, can you please add documentation for this attribute?
> This documentation isn't correct. Please see the other attributes (and AttrDocs.td) for an example of how to add the documentation.
Yes, sorry for that. I haven't compile it before sending patch. Is the documentation string good at least?


More information about the cfe-commits mailing list