[PATCH] D33852: Enable __declspec(selectany) on linux

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 04:44:14 PDT 2017


aaron.ballman added inline comments.


================
Comment at: include/clang/Basic/Attr.td:2477
   let Spellings = [Declspec<"selectany">, GCC<"selectany">];
   let Documentation = [Undocumented];
 }
----------------
aaron.ballman wrote:
> Since we're drastically modifying what platforms this is supported on, can you please add documentation for this attribute?
This documentation isn't correct. Please see the other attributes (and AttrDocs.td) for an example of how to add the documentation.


https://reviews.llvm.org/D33852





More information about the cfe-commits mailing list