[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 30 10:43:12 PDT 2017
erichkeane added a comment.
In https://reviews.llvm.org/D36272#856849, @anatol.pomozov wrote:
> > if we corrected the attribute spelling to be GCC instead of GNU and added some documentation to the attribute
>
> These are great suggestions! But I think it makes more sense to have a separate change for it as it orthogonal to what I am trying to do here. Having separate commits for independent changes is better as it makes things like bisecting and rollbacks easier.
I tend to agree, however I suspect Aaron really wants it done. Any chance you could submit a review to make that change? *Please* :)
https://reviews.llvm.org/D36272
More information about the cfe-commits
mailing list