[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

Anatol Pomozov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 10:35:18 PDT 2017

anatol.pomozov added a comment.

> As I said, as long as BOTH windows versions have the same issue, I think _I_ am OK with it.

The tests fail at windows the same way. The only difference - "attribute is not supported at 64bit" compiler warning is gone with my change.

> if we corrected the attribute spelling to be GCC instead of GNU and added some documentation to the attribute

These are great suggestions! But I think it makes more sense to have a separate change for it as it orthogonal to what I am trying to do here. Having separate commits for independent changes is better as it makes things like bisecting and rollbacks easier.


More information about the cfe-commits mailing list