[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 30 08:25:30 PDT 2017
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D36272#856040, @anatol.pomozov wrote:
> Hi Eric, thank you for your reply. Both these triples are currently broken, with my change and without.
> The attribute functionality in WinX86_64TargetCodeGenInfo mirrors one in X86_64TargetCodeGenInfo and it should work the same way. It is done intentionally as both these systems have the stack alignment restrictions.
> In addition to option you proposed there are other ways to make the forward progress:
> - fix function-attributes.c for win32 systems (both 32 and 64bit). Having working tests is important not only for force_align_arg_pointer functionality but for any other win32 change. It needs attention from Clang developers who is familiar with this area.
> - bypass the broken win32 test as it is done up until now.
As I said, as long as BOTH windows versions have the same issue, I think _I_ am OK with it. Since x86-windows already didn't work, you've simply added x64-windows support, which seems like a win to me. I think I'm ok with this for now, so I'll approve.
Hope that is OK Aaron :)
More information about the cfe-commits