[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

Anatol Pomozov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 15:57:33 PDT 2017

anatol.pomozov added a comment.

Hi Eric, thank you for your reply. Both these triples are currently broken, with my change and without.

The attribute functionality in WinX86_64TargetCodeGenInfo mirrors one in X86_64TargetCodeGenInfo and it should work the same way. It is done intentionally as both these systems have the stack alignment restrictions.

In addition to option you proposed there are other ways to make forward progress:

- fix function-attributes.c for win32 systems (both 32 and 64bit). Having working tests in important not only for force_align_arg_pointer functionality but for any other win32 change. It needs attention from Clang developers who is familiar with this area.
- bypass the broken win32 test as it is done up until now.


More information about the cfe-commits mailing list