[PATCH] D36171: AMDGPU: Use direct struct returns

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:7386
+  bool isHomogeneousAggregateBaseType(QualType Ty) const override;
+  bool isHomogeneousAggregateSmallEnough(const Type *Base,
+                                         uint64_t Members) const override;
----------------
yaxunl wrote:
> Please add descriptions for the above newly added functions.
I prefer not to put descriptions on overrides since they will just be out of date with the declaration


================
Comment at: lib/CodeGen/TargetInfo.cpp:7401
+bool AMDGPUABIInfo::isHomogeneousAggregateBaseType(QualType Ty) const {
+  return true;
+}
----------------
yaxunl wrote:
> why do we need this function if it always return true
The default is return false


https://reviews.llvm.org/D36171