[PATCH] D36171: AMDGPU: Use direct struct returns
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 8 12:24:24 PDT 2017
yaxunl added inline comments.
================
Comment at: lib/CodeGen/TargetInfo.cpp:7386
+ bool isHomogeneousAggregateBaseType(QualType Ty) const override;
+ bool isHomogeneousAggregateSmallEnough(const Type *Base,
+ uint64_t Members) const override;
----------------
Please add descriptions for the above newly added functions.
================
Comment at: lib/CodeGen/TargetInfo.cpp:7401
+bool AMDGPUABIInfo::isHomogeneousAggregateBaseType(QualType Ty) const {
+ return true;
+}
----------------
why do we need this function if it always return true
https://reviews.llvm.org/D36171
More information about the cfe-commits
mailing list