[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: lib/Driver/ToolChains/MinGW.cpp:130
+  case llvm::Triple::arm:
+  case llvm::Triple::thumb:
     CmdArgs.push_back("thumb2pe");
----------------
martell wrote:
> I believe this was left incase someone wanted to do windows ce in future.
> Can you add a todo like in CrossWindows.cpp in this case
> `// FIXME: this is incorrect for WinCE`
> or if we don't care about WinCE anymore just remove the TODO from CrossWindows?
Sure, I can add a todo. I wanted to add it, since technically, the modern windows on arm stuff is thumb, we should handle it if the user uses the triple thumbv7-windows-gnu (iirc, some of the tests do).


https://reviews.llvm.org/D36364