[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target
Martell Malone via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Aug 6 07:36:27 PDT 2017
martell added inline comments.
================
Comment at: lib/Driver/ToolChains/MinGW.cpp:130
+ case llvm::Triple::arm:
+ case llvm::Triple::thumb:
CmdArgs.push_back("thumb2pe");
----------------
I believe this was left incase someone wanted to do windows ce in future.
Can you add a todo like in CrossWindows.cpp in this case
`// FIXME: this is incorrect for WinCE`
or if we don't care about WinCE anymore just remove the TODO from CrossWindows?
https://reviews.llvm.org/D36364
More information about the cfe-commits
mailing list