[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

[Dehao Chen via Phabricator via cfe-commits]

danielcdh marked 2 inline comments as done.
danielcdh added inline comments.


================
Comment at: lib/CodeGen/BackendUtil.cpp:847-859
   if (PGOOpt.RunProfileGen)
     PGOOpt.ProfileGenFile = CodeGenOpts.InstrProfileOutput.empty() ?
       DefaultProfileGenName : CodeGenOpts.InstrProfileOutput;
 
   // -fprofile-use.
   if (CodeGenOpts.hasProfileIRUse())
     PGOOpt.ProfileUseFile = CodeGenOpts.ProfileInstrumentUsePath;
----------------
chandlerc wrote:
> At least some of these seem mutually exclusive, so show that with `else if`?
> 
> I wonder, are all of these mutually exclusive?
-fprofile-generate, -fprofile-use and -fprofile-sample-use are mutually exclusive.


https://reviews.llvm.org/D35746