[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

[Chandler Carruth via Phabricator via cfe-commits]

chandlerc added inline comments.


================
Comment at: lib/CodeGen/BackendUtil.cpp:843
 
   PGOOptions PGOOpt;
 
----------------
Maybe make this an optional to avoid the big predicate below?


================
Comment at: lib/CodeGen/BackendUtil.cpp:847-859
   if (PGOOpt.RunProfileGen)
     PGOOpt.ProfileGenFile = CodeGenOpts.InstrProfileOutput.empty() ?
       DefaultProfileGenName : CodeGenOpts.InstrProfileOutput;
 
   // -fprofile-use.
   if (CodeGenOpts.hasProfileIRUse())
     PGOOpt.ProfileUseFile = CodeGenOpts.ProfileInstrumentUsePath;
----------------
At least some of these seem mutually exclusive, so show that with `else if`?

I wonder, are all of these mutually exclusive?


https://reviews.llvm.org/D35746