[PATCH] D35538: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

David Majnemer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 21:37:55 PDT 2017


majnemer added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:5625
+  // The Run-time ABI for the ARM Architecture section 4.1.2 requires
+  // AEABI-complying FP helper functions to use the base AAPCS
+  // These AEABI functions are expanded in the ARM llvm backend, all the builtin
----------------
Period at the end of a sentence.


================
Comment at: test/CodeGen/arm-float-helpers.c:32
+// Note that it is only the functions in 4.1.2 that must use the base AAPCS,
+// other runtime functions such as the _Complex helper routines are not covered
+
----------------
Ditto.


================
Comment at: test/CodeGen/complex-math.c:482
+  // Run-time ABI for the ARM architecture document so they must not always
+  // use the base AAPCS
+
----------------
Ditto.


https://reviews.llvm.org/D35538





More information about the cfe-commits mailing list