[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added inline comments.


================
Comment at: src/cxa_demangle.cpp:44
 
+class string_ref
+{
----------------
dexonsmith wrote:
> erik.pilkington wrote:
> > mehdi_amini wrote:
> > > If this is supposed to be *the* ultimate LLVM demangler, can we follow LLVM coding standard?
> > I would like if this followed LLVM conventions too, but this file is already written following this style and leaving it in some middle state would be ugly. All of libcxx[abi] follows this convention too, so this isn't a problem that is isolated to this file.
> I agree.  I'd be fine with clang-formatting the entire project, but that seems independent from this change.
I'm not talking about pure "clang-format" but also naming for instance.

> I would like if this followed LLVM conventions too, but this file is already written following this style and leaving it in some middle state would be ugly.

Right, but in the meantime you're adding a significant amount of "debt".

> All of libcxx[abi] follows this convention too, so this isn't a problem that is isolated to this file.

This file is "special": it is shared (duplicated...) with LLVM.



https://reviews.llvm.org/D35159