[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

This LGTM.  Mehdi, do you have any other concerns?



================
Comment at: src/cxa_demangle.cpp:44
 
+class string_ref
+{
----------------
erik.pilkington wrote:
> mehdi_amini wrote:
> > If this is supposed to be *the* ultimate LLVM demangler, can we follow LLVM coding standard?
> I would like if this followed LLVM conventions too, but this file is already written following this style and leaving it in some middle state would be ugly. All of libcxx[abi] follows this convention too, so this isn't a problem that is isolated to this file.
I agree.  I'd be fine with clang-formatting the entire project, but that seems independent from this change.


https://reviews.llvm.org/D35159