[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

[Renato Golin via Phabricator via cfe-commits]

rengolin added a reviewer: jmolloy.
rengolin added a subscriber: jmolloy.
rengolin added a comment.

@jmolloy Can you check this change, please?



================
Comment at: lib/Basic/Targets.cpp:6245
   enum FPUModeEnum {
-    FPUMode,
-    NeonMode
+    NeonMode = (1 << 0),
+    SveMode = (1 << 1)
----------------
aemerson wrote:
> rengolin wrote:
> > Is there any AArch64 arch without SIMD?
> > 
> > Anyway, that seems deliberate, @t.p.northover any idea?
> SIMD support can be disabled with +nosimd. This change doesn't affect how that works.
The commit that introduced this (by James) states: "Allow the disabling of NEON and crypto instructions."

I wouldn't remove the FPUMode as is.

It's also surprising that this passes the test that James updated on the same commit. Maybe the tests weren't good enough?


Repository:
  rL LLVM

https://reviews.llvm.org/D35118