[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 7 08:20:32 PDT 2017


alexfh added a comment.

In https://reviews.llvm.org/D20693#775153, @alexfh wrote:

> In https://reviews.llvm.org/D20693#775014, @hintonda wrote:
>
> > - Only pass %2 parameter if %2 is included in format.
>
>
> I thought, DiagnosticsBuilder handles placeholders in conditional parts correctly. Did you find an evidence of the opposite? Can you add a test that consistently fails?


(without your latest change that is)


https://reviews.llvm.org/D20693





More information about the cfe-commits mailing list