[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In https://reviews.llvm.org/D20693#775014, @hintonda wrote:

> - Only pass %2 parameter if %2 is included in format.


I thought, DiagnosticsBuilder handles placeholders in conditional parts correctly. Did you find an evidence of the opposite? Can you add a test that consistently fails?



================
Comment at: clang-tidy/modernize/UseNoexceptCheck.h:42
+  const std::string NoexceptMacro;
+  bool UseNoexceptFalse;
+};
----------------
This can also be `const` for consistency with how options are handled in this and other checks.


https://reviews.llvm.org/D20693